spaceduck/neofsn
Watch
1
0
Fork
You've already forked neofsn
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove dead selection-feedback code and other unused remnants #4

Merged
bnied merged 0 commits from refs/pull/4/head into main 2026-06-07 20:51:49 +00:00
Conversation 0 Commits - Files changed -
bnied commented 2026-06-07 20:45:44 +00:00 (Migrated from codeberg.org)
Copy link

The selection spotlight, corona, and volumetric cone were built once and parked
at opacity 0 — never activated; the selection ring is the only live feedback.
Removed that whole subsystem and a few smaller dead remnants (−278 lines).

  • configureSelectionSpotlight / configureSelectionCorona / configureSelectionCone
    and their init calls; moveCorona, moveCone, makeCoronaTexture,
    makeSelectionRingShape; the spotlight/corona/cone nodes and cone/corona base
    constants; and the dead re-zeroing in hideSpotlight.
  • lastHalfExtent (write-only), focusLabelNodes + clearFocusLabels (always-empty
    no-op), and the always-false name == "focusLabel" branch in SceneBuilder.

Kept the live selection ring (configureSelectionRing, selectionRingTexture,
moveSpotlight, hideSpotlight, footprint, boxHeight). Verified the scene still
renders and the selection halo still draws.

The selection spotlight, corona, and volumetric cone were built once and parked at opacity 0 — never activated; the selection ring is the only live feedback. Removed that whole subsystem and a few smaller dead remnants (−278 lines). - configureSelectionSpotlight / configureSelectionCorona / configureSelectionCone and their init calls; moveCorona, moveCone, makeCoronaTexture, makeSelectionRingShape; the spotlight/corona/cone nodes and cone/corona base constants; and the dead re-zeroing in hideSpotlight. - lastHalfExtent (write-only), focusLabelNodes + clearFocusLabels (always-empty no-op), and the always-false `name == "focusLabel"` branch in SceneBuilder. Kept the live selection ring (configureSelectionRing, selectionRingTexture, moveSpotlight, hideSpotlight, footprint, boxHeight). Verified the scene still renders and the selection halo still draws.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
spaceduck/neofsn!4
No description provided.